Ticket #28 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Genshi templates include extra, empty html/body tags

Reported by: brian Assigned to: ian
Priority: major Milestone: 0.1
Component: admin templates Version: 0.1a1
Keywords: Cc:

Description

This appears at the top of all our templates:

<html> </html> <body> </body>

Something about our py:match is not right.

Change History

08/03/07 04:30:18 changed by brian

  • owner set to ian.

08/08/07 21:19:03 changed by ian

  • status changed from new to closed.
  • resolution set to fixed.

Resolved in r528

There were two problems causing this. The first problem was that admin.html had a body tag in there that wasn't necessary. I didn't take it out though, I just changed it to use py:match so that admin.html would still be a valid html document, and there won't be any extra body tags. Seems to be working fine.

The next problem was the py:strip that was on some of the html tags in the templates. Although Brian pointed out that it would be nice if we only had py:strip in base.html - so that people could extend edit.html more easily - it turns out that due to the include order of the templates, this is just not possible. We need py:strip in base.html and admin.html - and not in any of the first-level templates (edit.html, live.html, etc)

Log in as guest/pagoda to create tickets